Update testcafe version to 3.6.2 #28075
Conversation
…en diffs related to new chrome headless mode
…lue, fix 1 test in form
| @@ -9,6 +9,10 @@ import { appendElementTo } from '../../helpers/domUtils'; | |||
| fixture.disablePageReloads`ChatAvatar` | |||
| .page(url(__dirname, '../container.html')); | |||
|
|
|||
| test('Native automation check', async t => { | |||
| await t.expect(t.browser.nativeAutomation).ok(); | |||
| //the test continues only if you use native automation | |||
There was a problem hiding this comment.
I don't understand this change.
Why it should be enabled if u disable it in a general config?
Why this test should be exactly for chat Avatar?
There was a problem hiding this comment.
should be deleted, artifact of testing phase
e2e/testcafe-devextreme/runner.js
Outdated
| @@ -159,9 +159,9 @@ function setShadowDom(args) { | |||
| function expandBrowserAlias(browser) { | |||
| switch(browser) { | |||
| case 'chrome:devextreme-shr2': | |||
| return 'chrome:headless --disable-gpu --window-size=1200,800'; | |||
| return 'chrome:headless --disable-gpu --window-size=1200,1000'; | |||
There was a problem hiding this comment.
hmmm., why?
Should be reviewed by @EugeniyKiyashko
| break; | ||
| default: | ||
| sizes = [1200, 800]; | ||
| } |
There was a problem hiding this comment.
That's very strange for me.
At least it can be refactored to reduce copypaste.
But I'm not quire sure it's okay to specify component-specific sized on a runner level
| @@ -2,9 +2,9 @@ | |||
| type BrowserSizeType = [width: number, height: number]; | |||
| const DEFAULT_BROWSER_SIZE: BrowserSizeType = [1200, 800]; | |||
|
|
|||
| const restoreBrowserSize = async (t: TestController): | |||
| const restoreBrowserSize = async (t: TestController, sizeRestoreTo?: BrowserSizeType): | |||
There was a problem hiding this comment.
I don't think it's ok you're specifying non-default size for form test on runner level and then extend restoreBrowserSize to restore it to a non-default size manually
There was a problem hiding this comment.
We should understand why root input hover indication is missing now
There was a problem hiding this comment.
It can be a flaky scenario
| @@ -4,7 +4,8 @@ | |||
| ], | |||
| "screenshots": { | |||
| "path": "./", | |||
| "pathPattern": "${TEST}.png" | |||
| "pathPattern": "${TEST}.png", | |||
| "textDiffTreshold": 0.1 | |||
There was a problem hiding this comment.
For what scenarios is this setting necessary? Does it affect all etalons and does it not work without it?
There was a problem hiding this comment.
It can be a flaky scenario
| @@ -126,7 +126,7 @@ | |||
| "stylelint-config-recommended-vue": "1.5.0", | |||
| "stylelint-config-standard": "35.0.0", | |||
| "systemjs-builder": "0.16.15", | |||
| "testcafe": "2.6.2", | |||
| "testcafe": "3.6.2", | |||
There was a problem hiding this comment.
Can we separate the version update for the demos and the DevExtreme repository? In this case, the changes will be more obvious.
No description provided.